mlpack / mlpack/benchmarks

Collect better error messages from failures

Open
#122 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
107
Forks
46
PR merge metrics
No merged PRs in 30d

Description

Sometimes failures can give us results like:

Traceback (most recent call last):
  File "/home/jenkins/workspace/pull-requests-benchmarks-benchmark/tests/benchmark_decision_tree.py", line 261, in test_RunMetrics
    self.assertTrue(result["Runtime"] > 0)
TypeError: 'int' object is not subscriptable

with stdout

[FATAL] Could not execute command:
orkspace/pull-requests-benchmarks-benchmark/libraries/bin/mlpack_decision_tree',
'-t', 'datasets/iris_train.csv', '-T', 'datasets/iris_test.csv', '-v', '-p',
'mlpack_dct_predict.csv'] The error is: Command
orkspace/pull-requests-benchmarks-benchmark/libraries/bin/mlpack_decision_tree',
'-t', 'datasets/iris_train.csv', '-T', 'datasets/iris_test.csv', '-v', '-p',
'mlpack_dct_predict.csv']' returned non-zero exit status -6

It would probably be helpful if we could provide the actual stdout or stderr output from the subprocess calls.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the subprocess calls used by the benchmark scripts, using tests/benchmark_decision_tree.py and its failure output as the example. Confirm how non-zero exit statuses are handled, then run the affected benchmark test and verify that relevant stdout or stderr is included in the reported failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.