mlfoundations / mlfoundations/datacomp
--output_dir does not do correct thing if --output_dir is a cloud path
Open
@Vaishaal is already working on this.
Since Jul 21, 2023.
- Dominant language
- Python
- Stars
- 792
- Forks
- 65
- PR merge metrics
- No merged PRs in 30d
Description
The datacomp repo is cloudpath aware but open_clip is not, so when we pass a cloudpath like s3:// ... to the open_clip training code it just creates a folder called s3 locally on the master node.
The correct thing to do here is to detect its a cloudpath, give a temporary local directory and enable remote_sync on open_clip
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.