mlcommons / mlcommons/power-dev

Recent changes add whitespace line at the end of spl.txt files

Open
#326 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
28
Forks
30
PR merge metrics
No merged PRs in 30d

Description

A companion to https://github.com/mlcommons/inference/issues/1581

A workaround is provided with two PRs:

This will work for v4.0 submitters who have already generated some experiments.

Ideally, we should locate the change that altered the file structure, and amend it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the changes that generate or modify spl.txt files, then compare them with the workaround PRs power-dev/pull/325 and inference/pull/1584. The work is done when the relevant file structure no longer adds an extra whitespace line for newly generated experiments.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.