mlcommons / mlcommons/modelbench

Search for config directory up the tree

Open
#877 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
134
Forks
36
Avg merge
1d 11h
Merged PRs (30d)
17

Description

Right now if you change into some subdirectory and run modelbench or modelgauge, it will look for a config directory only in the current directory. If there isn't one there, it creates a sample one and then usually fails out because of missing keys. The result of this is a lot of spurious config directories that have to be cleaned up.

What I'd like it to do is look up the directory stack. So if I'm in /home/william/projects/modelbench/experiments/french/runs and I run modelgauge run-csv-items it should look first in the current directory and then up at least as far as modelbench for a config directory with secrets.yaml, and possibly all the way up.

This is mainly in aid of creating analytics tools that are easier to use.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how modelbench and modelgauge currently locate the config directory when invoked from the current directory. Verify the lookup behavior from a nested path such as experiments/french/runs, including discovery of config/secrets.yaml in an ancestor and avoiding creation of a spurious sample config when one exists above.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.