mlcommons / mlcommons/inference
Codebase refactor : Fix security and safety issues
Open
A pull request for this has already been merged.
- #2489 by @arav-agarwal2 — merged
- Dominant language
- Python
- Stars
- 1.6k
- Forks
- 650
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 6
Description
Systematically eliminate unsafe execution patterns and document trust boundaries.
- Replace os.system() usage calls
- Replace evals() with safe alternatives
- Remove shell=True from subprocess calls
- Switch to HTTPS for dataset downloads and add checksum verifications
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the os.system() and evals() usage, subprocess calls with shell=True, and dataset download paths. Trace the trust boundaries around each case and document them; the work is done when unsafe execution patterns are replaced, downloads use HTTPS, and checksum verification is present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- security
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100