mlcommons / mlcommons/inference

Revisit Early stopping

Open
#2,322 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.6k
Forks
650
Avg merge
1d 22h
Merged PRs (30d)
6

Description

Early stopping and current validity check reporting is confusing.

For example, this deepseek run has 1.9 second TTFT. The validity checker still reports it as invalid because early stopping uses some different threshold as a validity criterion. This is not communicated clearly. Please refer to the example below.

Server Scenario:

+--------------------------------------+-------------+-----------+----------+-------------------------+----------------------------------\

--+------------------+------------------+

| System Name | Benchmark | Setting | Valid? | Per-query time usage | Metric Name \

| Measured Value | Avg. Power (W) |

+======================================+=============+===========+==========+=========================+==================================\

==+==================+==================+

| vSYS-422GA-NBRT-B200-SXM-180GBx8_TRT | deepseek-r1 | cp990 | INVALID | TTFT: 99.6%, TPOT: 75.8 | result_completed_tokens_per_secon\

d | 12331.70 | N/A |

+--------------------------------------+-------------+-----------+----------+-------------------------+----------------------------------\

--+------------------+------------------+

  • Note: 'Per-query time usage' is the measured 99th-percentile latency divided by the requested server latency. This value should not e\

xceed 100% for a 'VALID' result.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating the early-stopping implementation and validity-check reporting, then reproduce the deepseek-r1 example to compare their thresholds and messages. Done should include agreed behavior and clear reporting for cases where early stopping and validity criteria differ.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.