mlcommons / mlcommons/inference
Confusing mlcommon conf_type for the configuration file
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.6k
- Forks
- 650
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 6
Description
Currently the conf_type is not enumed, and it's very confusing what 0,1,2 means
https://github.com/mlcommons/inference/blob/d82d7d42ae9bfaff9941a6698954918504d8f0eb/loadgen/test_settings_internal.cc#L532
The pybinding: https://github.com/mlcommons/inference/blob/d82d7d42ae9bfaff9941a6698954918504d8f0eb/loadgen/bindings/python_api.cc#L351
Specify that conf_type=1 means loading user.conf, but in the actual code there is a weird block to load conf_type=0 with conf_type=1? (line540
I think we should:
- enum the conf_type, and clean up the logic there
- Report runtime error and exit immediately (for multiple conf file), instead of loadgen error that won't be caught until after the run
cc: @pgmpablo157321 @arjunsuresh
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with loadgen/test_settings_internal.cc around lines 532-540 and loadgen/bindings/python_api.cc around line 351. Trace how conf_type values 0, 1, and 2 are defined and how multiple configuration files are handled. Done means the values have clear enum semantics and invalid multiple-file use reports a runtime error immediately.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100