Variable ETFeederNode::num_ops_ can have uninitialized value
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 196
- Forks
- 84
- PR merge metrics
- No merged PRs in 30d
Description
Describe the Bug
The variable ETFeederNode::num_ops_ can have uninitialized value, as it might not be initialized in the constructor. This can lead to random behavior in Workload::issue() function (see condition checking here https://github.com/astra-sim/astra-sim/blame/master/astra-sim/workload/Workload.cc#L138)
Steps to Reproduce
Use any chakra file that has no num_ops field
Expected Behavior
The field num_ops_ should be initialized to default value of 0
Screenshots
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the ETFeederNode constructor and inspect the condition in astra-sim/workload/Workload.cc around line 138. Reproduce the issue with a Chakra file that omits num_ops, then verify that the field defaults to 0 and the resulting workload behavior is deterministic.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100