Chakra ETNode Comm Size Read Error
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 196
- Forks
- 84
- PR merge metrics
- No merged PRs in 30d
Description
Describe the Bug
When calling the et_feeder_node->comm_size() method of ETFeederNode, it is found that the read comm size is 0, but the expected result should not be 0.
After investigation, the acquisition failed because the type obtained in src/feeder/et_feeder_node.cpp:28 was attr.int64_val() instead of attr.uint64_val(). it causes the method to return a result of 0
// in src/feeder/et_feeder_node.cpp:28
ETFeederNode::ETFeederNode(std::shared_ptr<ChakraProtoMsg::Node> node) {
...
} else if (attr_name == "comm_size") {
this->comm_size_ = attr.int64_val(); // attr.uint64_val() method should be used here
...
}
Looking forward to fixing this bug and checking if there are similar issues elsewhere.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/feeder/et_feeder_node.cpp:28 and inspect how comm_size is read from the node attributes. Verify the unsigned value path and search the feeder code for similar integer-type mismatches. Done means comm_size is no longer read as zero for valid unsigned values and related checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100