mlcommons / mlcommons/algorithmic-efficiency

Add tests for expected number of evals submission and measured times

Open
#452 0 comments 0 reactions 1 assignee View on GitHub

@priyakasimbeg is already working on this.

Since Jul 25, 2023.

Good First Issue
Dominant language
Python
Stars
425
Forks
78
PR merge metrics
No merged PRs in 30d

Description

Description

Add CI test that checks if reported times and number of evals are inline with expectations.

For each submission we report:

  • total wall clock time
  • submission time
  • eval time
  • logging time
  • number of evals

We should add the following tests on at least 1 workload (probably mnist).

  1. We should check that submission_time + eval_time + logging time ~ total _wallclock_time.
  2. We should check that the number of evals is roughly equal to total_submission_time // eval_period

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.