mlc-ai / mlc-ai/tokenizers-cpp

When compiling with rustc 1.90.0 (rustup version 1.28.2), an error was encountered

Open Beginner friendly
#88 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
512
Forks
132
PR merge metrics
No merged PRs in 30d

Description

When compiling with rustc 1.90.0 (rustup version 1.28.2), an error was encountered,and how to solve it, thanks!

Compiling tokenizers-c v0.1.0 (/fg/build_in_docker/_deps/tokenizers_cpp-src/rust)
error: implicit autoref creates a reference to the dereference of a raw pointer
--> src/lib.rs:218:20
|
218 | *out_len = (*handle).decode_str.len();
| ^^------^^^^^^^^^^^^^^^^^^
| |
| this raw pointer has type *mut TokenizerWrapper
|
= note: creating a reference requires the pointer target to be valid and imposes aliasing requirements
note: autoref is being applied to this expression, resulting in: &std::string::String
--> src/lib.rs:218:20
|
218 | *out_len = (*handle).decode_str.len();
| ^^^^^^^^^^^^^^^^^^^^
note: method calls to len require a reference
--> /rustc/1159e78c4747b02ef996e55082b704c09b970588/library/alloc/src/string.rs:1854:5
= note: #[deny(dangerous_implicit_autorefs)] on by default
help: try using a raw pointer method instead; or if this reference is intentional, make it explicit
|
218 | *out_len = (&(*handle).decode_str).len();
| ++ +

error: implicit autoref creates a reference to the dereference of a raw pointer
--> src/lib.rs:251:20
|
251 | *out_len = (*handle).id_to_token_result.len();
| ^^------^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| this raw pointer has type *mut TokenizerWrapper
|
= note: creating a reference requires the pointer target to be valid and imposes aliasing requirements
note: autoref is being applied to this expression, resulting in: &std::string::String
--> src/lib.rs:251:20
|
251 | *out_len = (*handle).id_to_token_result.len();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: method calls to len require a reference
--> /rustc/1159e78c4747b02ef996e55082b704c09b970588/library/alloc/src/string.rs:1854:5
help: try using a raw pointer method instead; or if this reference is intentional, make it explicit
|
251 | *out_len = (&(*handle).id_to_token_result).len();
| ++ +

error: could not compile tokenizers-c (lib) due to 2 previous errors
gmake[2]: *** [_deps/tokenizers_cpp-build/release/libtokenizers_c.a] Error 101
gmake[1]: *** [_deps/tokenizers_cpp-build/CMakeFiles/tokenizers_c.dir/all] Error 2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect src/lib.rs at lines 218 and 251, where the compiler reports implicit autoref errors on raw-pointer field access. Compare the diagnostics and suggested expressions, then rebuild the tokenizers-c target through the shown CMake/gmake path. Done means the Rust library compiles successfully with rustc 1.90.0.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.