mlc-ai / mlc-ai/tokenizers-cpp

Why MLC_ENABLE_SENTENCEPIECE_TOKENIZER OFF by default?

Open
#45 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
512
Forks
132
PR merge metrics
No merged PRs in 30d

Description

Should MLC_ENABLE_SENTENCEPIECE_TOKENIZER be on by default in CMakeLists.txt? I had to turn it on in order to successfully run ./build_and_run.sh to build the example target. Otherwise, I get a assert failure at src/sentencepiece_tokenizer.cc:

#else
std::unique_ptr<Tokenizer> Tokenizer::FromBlobSentencePiece(const std::string& model_blob) {
  assert(false);
  throw;
}
#endif  // MLC_ENABLE_SENTENCEPIECE_TOKENIZER

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in CMakeLists.txt and inspect the default for MLC_ENABLE_SENTENCEPIECE_TOKENIZER, then trace the disabled path in src/sentencepiece_tokenizer.cc. Run ./build_and_run.sh with the current default and with the option enabled; done means the intended example target builds and runs without a manual configuration change, or the required configuration is clearly established.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.