mlabs-haskell / mlabs-haskell/purescript-aeson
Allow `constructor` property in Json
Open
Nobody has claimed this yet.
- Dominant language
- Nix
- Stars
- 6
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
> parseJsonStringToAeson "{\"constructor\": \"Just\"}"
(Left (TypeMismatch "JSON String"))
> parseJsonStringToAeson "{\"constructo\": \"Just\"}"
(Right {"constructo":"Just"})
it comes from our fork of json-bigint lib:
> jsonBigint.parse("{\"constructor\": \"Just\"}")
Uncaught:
{
name: 'SyntaxError',
message: 'Object contains forbidden constructor property',
at: 16,
text: '{"constructor": "Just"}'
}
We should probably initialize it with
{ constructorAction: 'preserve` }
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the parseJsonStringToAeson entry point and locate where the forked json-bigint parser is initialized. Compare the handling of constructor with constructo and verify the parser examples after the configuration change; done means JSON containing a constructor property parses successfully without changing other object-property behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100