mlabs-haskell / mlabs-haskell/lambda-buffers-for-cardano
Incorrect usage of the change output for `demo-haskell`'s produced `TxInfo`s
Nobody has claimed this yet.
- Dominant language
- Nix
- Stars
- 5
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
The change output in the TxInfo produced by demo-haskell most likely isn't correct (but the tests pass).
This was noticed by the following PR comment:
Perhaps, but that breaks certain assumptions we want to work with in the future. For example, we'll also use ledger-sim from TxVillage to evaluate the transaction and provide back the actual XU budget.
One less output means less XU which breaks that assumption. The overall idea is for the TxInfo to be manipulated in 'XU invariant structure' only at source (which is here) not at bake site.
Does that make sense?
Originally posted by @bladyjoker in https://github.com/mlabs-haskell/lambda-buffers-for-cardano/pull/27#discussion_r1808283175
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by examining how demo-haskell produces TxInfos and how the change output is constructed. Compare the result with the XU-invariant assumptions described in the linked PR discussion, and use the existing tests to verify the corrected transaction structure and budget assumptions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- haskell
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 32/100