mlabs-haskell / mlabs-haskell/bot-plutus-interface

awaitTxStatusChange hides rollbacks as `Unknown`

Open
#110 1 comment 0 reactions 1 assignee View on GitHub

@mikekeke is already working on this.

Since Jun 20, 2022.

Dominant language
Haskell
Stars
21
Forks
11
PR merge metrics
No merged PRs in 30d

Description

awaitTxStatusChange currently only returns Unknown or Committed.

In case of a rollback then we only ever get Unknown, which e.g. makes awaitTxConfirmed keep looping as if we were still waiting for the tx to show up at all.

As we discussed before, we should have awaitTxStatusChange actually return the current status of the transaction, rather than include the 8 block wait for confirmation.

Utilities built on top of this primitive can then implement an appropriate way to deal with rollbacks when they see TentativelyConfirmed followed by Unknown

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.