ml-opensource / ml-opensource/rest-api-server

Exception handler needs to handle exception subclassing

Open
#10 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
6
Forks
2
PR merge metrics
No merged PRs in 30d

Description

The exception handler currently only uses get_class() to determine the type of exception:

	/**
	 * Convert err to HttpException.
	 *
	 * @param mixed $err
	 *
	 * @return HttpException
	 */
	protected function toHttpException(Exception $err): HttpException
	{
		$errClass = get_class($err);

		switch ($errClass) {
			case HttpException::class:
				$httpErr = $err;
				break;

			// 404 Model not found.
			case ModelNotFoundException::class:
				$httpErr = $this->convertFromModelNotFound($err);
				break;

			case QueryException::class:
			default:
				$httpErr = $this->defaultHttpException();
				break;
		}

		return $httpErr;
	}

So throwing a BadRequestHttpException gets serialized to a 500 error instead of a 400 error.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the toHttpException method shown in the issue and inspect how exception classes are currently selected. Verify the behavior for BadRequestHttpException and other HttpException subclasses, then confirm that a bad-request exception produces a 400 response rather than a 500 response.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
api, backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.