ml-opensource / ml-opensource/admin-panel-template-reactjs

Layout remounts on every paths

Open
#148 0 comments 0 reactions 1 assignee View on GitHub

@rifat-ml is already working on this.

Since Jun 16, 2022.

  • #149 by @rifat-ml — closed without merging
bug
Dominant language
TypeScript
Stars
23
Forks
9
PR merge metrics
No merged PRs in 30d

Description

There are three types of layouts currently we've on this template:

  1. Blank Layout
  2. Sidebar Layout
  3. Header Layout

On public paths like authentication and registration, we've used the Blank Layout and for private paths, we've options to choose different layouts like Sidebar Layout and Header Layout. So whatever the layout is the same layout shouldn't be remounted on every path change. But currently, the same layout is remounting on every path change. That is an issue in some cases as the sidebar or navbar sometimes shuts and opens unexpectedly while toggling. And also it's a heavy operation on DOM to mount and unmount which is unnecessary in this situation.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.