ml-opensource / ml-opensource/RatingBar

Throw IllegalArgumentException if invalid parameters are set

Open
#13 0 comments 0 reactions 1 assignee View on GitHub

@raigex is already working on this.

Since Oct 25, 2016.

Dominant language
Java
Stars
21
Forks
6
No merged PRs in 30d

Description

The following situations should not be supported in v1:

  • StarSize is not specified or equal to 0 and any of the following are true
    1. Empty drawable and filled drawable are different sizes
    2. Empty drawable and filled drawable are both size 0
    3. Empty drawable is not a square
    4. Filled drawable is not a square

N.B. arbitrary rectangles may be supported in a future release

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.