ml-explore / ml-explore/mlx

Investigate using scikit-build-core

Open
#2,876 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement python
Dominant language
C++
Stars
28.5k
Forks
2.3k
Avg merge
3d 8h
Merged PRs (30d)
62

Description

scikit-build-core is a modern Python build backend that wraps CMake. It is ideal for projects like MLX that use cmake to build extensions. I'm trying to build mlx in support of #2807 and noticed the custom setuptools extensions that wrap cmake. It seems like there's a lot of overlap between the setup.py and scikit-build-core.

One nice feature of scikit-build-core is consistent build directories which would replace the need for setup.py build_ext and in-place builds in general for development.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with setup.py and the custom setuptools extensions that wrap CMake, then compare their responsibilities with scikit-build-core's documented configuration and consistent build directories. Define whether the build can be migrated without in-place development builds, and verify that the MLX CMake extension build still works.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, python
Domain
build-system
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.