ml-explore / ml-explore/mlx

[Feature] GPU scatter support for complex64

Open
#1,214 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement low priority
Dominant language
C++
Stars
28.5k
Forks
2.3k
Avg merge
3d 8h
Merged PRs (30d)
62

Description

I'm trying to implement a VQ-VAQ with a loss function which uses the log Mel spectrogram. I can train my network using MSE and L1 loss with float32 values, but when I apply the Mel transform to these arrays I get the following error

ValueError: [scatter] GPU scatter does not yet support complex64 for the input or updates.

Is this on the short-term roadmap? If not, I might try to implement the feature or maybe a short-term workaround.

System information:

  • OS Version: MacOS Sonoma 14.5
  • Version 0.15.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Begin with the GPU scatter implementation and the log Mel transform reproduction described in the issue. Trace where complex64 is rejected for scatter inputs or updates, then verify GPU scatter with complex64 no longer raises the reported ValueError and that the Mel transform path works.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.