ml-explore / ml-explore/mlx-examples
Add support for Llava-1.6
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 9k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
> @nkasmanoff @mzbac Great works! Do you plan to support [Llava-1.6-hf](https://huggingface.co/llava-hf/llava-v1.6-mistral-7b-hf) too ? It does require this change from transformers: [huggingface/transformers#29012](https://github.com/huggingface/transformers/pull/29012)
@nxphi47 would like to add support for llava 1.6, however, could you create an issue for that? Comments on the closed PR may get lost.
Originally posted by @mzbac in https://github.com/ml-explore/mlx-examples/issues/461#issuecomment-1975413383
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Start by locating the existing Llava support and reviewing the linked Transformers change and Llava-1.6-hf model details; done means the repository supports that model as requested and its behavior is covered by the relevant existing checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100