ml-explore / ml-explore/mlx-data
Is MLX_ENABLE_AWS environment variable required?
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 483
- Forks
- 62
- PR merge metrics
- No merged PRs in 30d
Description
Hello MLX Team,
I noticed that the MLX_ENABLE_AWS environment variable is currently specified when building mlx-data in .circleci/config.yml:
However, I encountered the following message during the build process:
-- Configuring done (8.7s)
-- Generating done (0.1s)
CMake Warning:
Manually-specified variables were not used by the project:
MLX_ENABLE_AWS
Based on my testing, the build remains unaffected even without this environment variable. Given this, would it be better to remove it?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the three MLX_ENABLE_AWS entries in .circleci/config.yml and checking whether the variable is referenced by the project's CMake configuration. Compare builds with and without it, then confirm the warning and build behavior before deciding whether all three entries can be removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system, ci-cd
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100