Tests failing - possible causing issues in Safari with sizing
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 293
- Forks
- 110
- PR merge metrics
- No merged PRs in 30d
Description
Tests: core module: setDimensions (3, 11, 14)
Fails:
-
failed, expected: 25 result: 50
-
failed, expected: 25 result: 50
-
failed, expected: 25 result: 50
In Safari 5 overlay not sizing correctly when displaying iframe player. Getting around 30-50px of padding even when the target HTML has margin & padding set to 0px. Displays fine in Mozilla.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the core module's setDimensions tests, especially cases 3, 11, and 14, and reproduce the failures in Safari 5 if that environment is available. Compare the overlay iframe sizing behavior with Mozilla and verify that the tests pass without the reported 30–50px padding.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100