mjackson / mjackson/shadowbox

Toolbar options in ckeditor loaded on a jquery shadowbox closes the shadowbox on click

Open
#53 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
293
Forks
110
PR merge metrics
No merged PRs in 30d

Description

I am using CKEDITOR 4.4.6 DEV and loading it on jquery shadowbox version "3.0rc1" as shown on screenshot below.

screenshot

On click of any of the toolbar options, the entire shadowbox closes! Below is the code for initializing ckeditor. May be some extra code to be added or i have missed something? Thankyou!

I have tried overriding window onclick with event.stopPropogation() but so far no results.

I am assuming some onclick event is triggering which i am not able to figure out?

Thanks

Just in case , code below:

JS

Shadowbox.init({
animate: false,
overlayColor: "#AAA"
});

html

rel='shadowbox;player=iframe;'

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with CKEditor 4.4.6 DEV and Shadowbox 3.0rc1, using the supplied Shadowbox initialization and iframe markup. Inspect the click handling around the toolbar and shadowbox, then verify that toolbar clicks no longer close the shadowbox.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, jquery
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.