shadowbox makes html invalid
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 293
- Forks
- 110
- PR merge metrics
- No merged PRs in 30d
Description
Nu Html Checker says:
ERROR Bad value shadowbox for attribute rel on element a: The string shadowbox is not a registered keyword.
Changing 'getAttribute("rel")' in shadowbox.js to 'getAttribute("data-foobar")' may solve it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in shadowbox.js at the getAttribute("rel") call. Check the suggested attribute change, then run the Nu Html Checker against the affected HTML and confirm that the lightbox behavior still works without the invalid rel keyword.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100