mjackson / mjackson/shadowbox

Using external page properties to dynamically set width and height?

Open
#34 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
293
Forks
110
PR merge metrics
No merged PRs in 30d

Description

When using the "external sites and pages" player along with jQuery, is it possible to get some CSS properties of the external page to dynamically set the width and height of Shadowbox?

For example, something to the effect of this:

Shadowbox.setup($('.sb-page'), {
height: $(target page's element).height(),
width: $(target page's element).width()
});

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names Shadowbox, the external sites and pages player, and jQuery, but no source file, test, or entry point. First inspect the player’s sizing and external-page integration code; done would mean establishing whether target-page dimensions can be read and used reliably to set Shadowbox width and height.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, jquery
Domain
frontend, web-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.