mjackson / mjackson/shadowbox

supportsFixed returns false positive for MobileSafari

Open
#12 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
293
Forks
110
PR merge metrics
No merged PRs in 30d

Description

The supportsFixed test returns positive for MobileSafari. Although MobileSafari does in a sense support fixed positioning, the practical reality is that the shadowbox appears off screen when the user is scrolled down. I believe that modifying the supportsFixed feature test to return false for MobileSafari would rectify this issue.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the supportsFixed feature test and checking how it evaluates MobileSafari. Reproduce the off-screen shadowbox behavior while scrolled, then verify that the test no longer reports fixed positioning as supported for MobileSafari.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.