mjackson / mjackson/http-client
Avoid the use of eval()
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 503
- Forks
- 23
- PR merge metrics
- No merged PRs in 30d
Description
I'm in the process of activating CSP for a project. Thereby I, or better the browser, noticed that http-client internally uses eval().
I haven't quite figured out why this necessary at this place, but I'd like to have it replaced with a non eval-construct. Can you help me out?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in modules/index.js at the eval() use identified in the issue and trace why it is needed in the HTTP client composition path. Replace that construct with a CSP-compatible approach while preserving the existing client behavior, then verify the project’s existing checks still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api, security
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100