miyakei1225 / miyakei1225/React_tutorial

const & hooksをしっかり使えているので、ここも対応したら最高だな〜と思った!

Open
#1 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

とても良いと思ったこと

関数コンポーネントのメリットや、できるだけconst & hooksを使って、コードを書いているのとても良いと思いました!

細かいけど気になったこと

上記のように、良いものが書けていると思うので、
下記についてもletを使った処理から、consthooksを活用する処理に変えられたら、「最高〜」と思いました!

https://github.com/miyakei1225/React_tutorial/blob/8b0a1c4c1453b53e7139cc0fd3192cf84dfcf12f/src/index.js#L89-L94

https://github.com/miyakei1225/React_tutorial/blob/8b0a1c4c1453b53e7139cc0fd3192cf84dfcf12f/src/index.js#L123-L128

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading src/index.js at lines 89-94 and 123-128, the two locations identified in the issue. Compare the existing let-based processing with the surrounding function-component and hooks usage. Done means both sections use the requested const or hooks-based approach without changing the tutorial's behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.