miyakei1225 / miyakei1225/React_tutorial
const & hooksをしっかり使えているので、ここも対応したら最高だな〜と思った!
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
とても良いと思ったこと
関数コンポーネントのメリットや、できるだけconst & hooksを使って、コードを書いているのとても良いと思いました!
細かいけど気になったこと
上記のように、良いものが書けていると思うので、
下記についてもletを使った処理から、constやhooksを活用する処理に変えられたら、「最高〜」と思いました!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading src/index.js at lines 89-94 and 123-128, the two locations identified in the issue. Compare the existing let-based processing with the surrounding function-component and hooks usage. Done means both sections use the requested const or hooks-based approach without changing the tutorial's behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100