mitre / mitre/nuxt-github-pages

file duplication occurs before `@nuxtjs/critters`

Open
#24 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

When using @nuxtjs/critters to inline css, it runs after the nuxt-github-pages, resulting in the duplicated pages not having inlined css.

this seems to occur regardless of the order the modules are registered.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Reproduce a Nuxt build using @nuxtjs/critters and nuxt-github-pages with both module registration orders, then inspect the module lifecycle or build entry points to determine when page duplication occurs. Done means duplicated pages also contain the inlined CSS.

Written by the indexing model from the issue text.

Assessment

Tech stack
nuxtjs, typescript
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.