mitre / mitre/HTTP-Proxy-Servlet
Convert private functions to protected
Open
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.5k
- Forks
- 557
- PR merge metrics
- No merged PRs in 30d
Description
Any particular reason that the functions setXForwardedForHeader and getContentLength are not protected instead of private? This allows others to extend this class without the need to modify it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate setXForwardedForHeader and getContentLength in the servlet code and inspect their callers and surrounding visibility conventions. Change only the requested visibility if appropriate, then verify that existing behavior is unchanged and that subclasses can access both methods.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100