mitre / mitre/HTTP-Proxy-Servlet

Cookie Domain Not Copied

Open
#162 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
1.5k
Forks
557
PR merge metrics
No merged PRs in 30d

Description

In ProxyServlet.copyProxyCookie() there's a comment

don't set cookie domain

Why is that? In my case I need this.
Would you agree to have a parameter to enable copying the domain? Of course it only makes sense when the domain is part of the used host.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in ProxyServlet.copyProxyCookie(), where the issue identifies the existing decision not to set the cookie domain. Review how cookie domains relate to the used host and determine the parameter needed to enable copying them safely. Done means the behavior can be enabled when appropriate without changing the default behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.