mitre / mitre/HTTP-Proxy-Servlet
Cookies are lost
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.5k
- Forks
- 557
- PR merge metrics
- No merged PRs in 30d
Description
getRealCookie strips cookie values.
The escapedCookie StringBuilder is only ever appended to if the cookie name starts with the internally generated name and yet it is always the return value from the method. All regular cookies coming from the browser end up stripped.
The workaround is to subclass the servlet and override getRealCookie to do nothing since it seems to be of marginal utility compared to the general case.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open src/main/java/org/mitre/dsmiley/httpproxy/ProxyServlet.java at getRealCookie and trace how escapedCookie is built and returned. Verify the behavior with a regular browser cookie and consider the internally generated cookie case; done means ordinary cookie values are preserved rather than stripped.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100