mitre-attack / mitre-attack/attack-workbench-frontend

[BUG] Highlight only changed relationship rows in diff tables

Open
#950 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
438
Forks
79
Avg merge
1d 21h
Merged PRs (30d)
3

Description

Describe the bug
When one Procedure Example changes in a diff, every Procedure Examples table row is highlighted as changed, rather than only the affected STIX relationship object.

Expected behavior
Only the added, removed, or modified Procedure Example row should be highlighted.

To Reproduce
Steps to reproduce the behavior:

  1. Open a candidate object with a diff containing a change to one Procedure Example.
  2. Open the diff view.
  3. Select the Procedure Examples tab.
  4. Observe that all rows are highlighted as changed.

Additional context
This should be corrected for relationship-based diff tables so reviewers can identify the specific changed relationship.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by opening a candidate object with a change to one Procedure Example, then inspect the diff view's Procedure Examples tab and the relationship-based diff table handling. Trace how rows are matched to added, removed, or modified STIX relationship objects. Done means only the affected relationship row is highlighted while unchanged rows remain unhighlighted.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.