mitre-attack / mitre-attack/attack-workbench-frontend
[REQUEST] Add Promote action to the diff view
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 438
- Forks
- 79
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 3
Description
Is your feature request related to a problem? Please describe.
After opening a candidate’s diff view, users must close the modal to promote the object, adding an unnecessary step to the review workflow.
Describe the solution you'd like
Add a Promote button to the diff modal for eligible candidate objects. It should perform the same promotion action as the button on the member card.
Describe alternatives you've considered
Close the diff modal and use the Promote button on the corresponding member card.
Additional context
The button should respect existing permissions and only appear when promotion is available.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the diff modal and the corresponding member-card Promote action in the Angular frontend. Compare how the existing action handles eligibility and permissions, then add the modal action with the same behavior. Done means eligible candidates can be promoted from the diff modal, while the button remains hidden when promotion is unavailable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100