mitre-attack / mitre-attack/attack-workbench-frontend
[REQUEST] Add Comments and Approval Feature to Collection Manager
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 438
- Forks
- 79
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 3
Description
Draft collections in the Collection Manager lack the ability for users to leave comments or mark collections as approved, making the review process less efficient.
Solution:
Introduce a feature in the Collection Manager that allows users to add comments on draft collections and provides an option for Team Leads to mark them as approved once reviewed.
Potential Implementations
- Add a comment section for each draft collection, enabling users to leave their feedback.
- Create an "Approve" button that Team Leads can use to finalize collections.
- Provide notifications for comments and approval actions to keep team members informed.
- Implement a status indicator (e.g., "Draft", "In Review", "Approved") to reflect the collection's current stage
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Collection Manager and its draft collection review workflow. Define how comments, Team Lead approval, notifications, and the Draft/In Review/Approved status indicator should fit together. Done means users can comment on draft collections, Team Leads can approve them, and the resulting status and notifications are visible to the relevant team members.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100