mitre-attack / mitre-attack/attack-website
Bleach is deprecated
@seansica is already working on this.
Since Jun 28, 2023.
- Dominant language
- HTML
- Stars
- 588
- Forks
- 174
- Avg merge
- 13d 4h
- Merged PRs (30d)
- 2
Description
Per Mozilla, as of Jan 23, Bleach is deprecated: https://github.com/mozilla/bleach/issues/698#issue-1553425406
They will continue to provide security updates and bug fixes for approximately one year.
We need to replace Bleach.
ammonia looks like a promising solution but there may be others.
This is a good opportunity to refactor a bit. The process of sanitizing the HTML and generating the seed file (index.json) for the search index should be decoupled. There ought to be a separation of concerns between the generation of the website content and the generation of the search index.
Order of events:
- Build website (Pelican/update-attack.py)
- Generate seed file for search index (e.g., ammonia)
- Generate search index (attack-search --> npm/webpack)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.