mitre-attack / mitre-attack/attack-navigator

Since Navigator 4.5.5 suddenly there's an underline color when metadata is filled

Open
#400 2 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement Points: 3 seeking feedback
Dominant language
TypeScript
Stars
2.5k
Forks
715
Avg merge
7h 33m
Merged PRs (30d)
4

Description

hi there!

Since latest 4.5.5 release of the Navigator, all layers suddenly have underlines for techniques:

Screenshot 2022-01-11 at 14 34 23

Before this new Navigator version, you only get an underline when you have filled in a comment. But now, it will also give an underline when having metadata.

I see this is done on purpose in this commit:
https://github.com/mitre-attack/attack-navigator/commit/bc4ad9fd105c9fa68c12e04a0505b60d3124c655#diff-e49d1d934cc9d96bce820fb261164a66e14c3c90fa2364ff83b6d12201992182

There's now a function getTechniqueUnderlineColor that determines the underline when this condition is true:
tvm.comment.length > 0 || tvm.metadata.length > 0 || this.hasNotes()

Instead of only when no comment is filled in (how it was before):
<span [style.border-color]="configService.getFeature('comment_underline') ? configService.comment_color: ''" [style.color]="getTechniqueTextColor()">

This change has a huge impact. It makes Navigator layers, and thus also the layers of users using DeTT&CT, significantly less attractive and hence less usable for presenting results. See examples beneath how it looks like when you create layers with DeTT&CT.

We propose to undo this change of underlining. Or give a possibility to influence this.

Screenshot 2022-01-11 at 14 46 07 Screenshot 2022-01-11 at 14 46 15 Screenshot 2022-01-11 at 14 46 23

Regards,
Ruben

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the commit linked in the issue and the getTechniqueUnderlineColor function, then reproduce the underline behavior with metadata and with comments. Done means restoring the previous comment-only underline behavior or adding a way to control metadata underlines, with the affected Navigator presentation verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.