mitmproxy / mitmproxy/mitmproxy
mitmproxy_rs CI: Upgrade swift-protobuf
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 45.1k
- Forks
- 4.7k
- Avg merge
- 21h 12m
- Merged PRs (30d)
- 16
Description
Problem Description
swift-protobuf 1.31.0 changes the generated Swift files so that they are incompatible with our current version of SwiftProtobuf. We need to update SwiftProtobuf and then re-enable swift-protobuf in our autofix CI job.
Details: https://github.com/mitmproxy/mitmproxy_rs/pull/282/
/Users/runner/work/mitmproxy_rs/mitmproxy_rs/mitmproxy-macos/redirector/ipc/mitmproxy_ipc.pb.swift:285:67: error: argument passed to call that takes no arguments
static let _protobuf_nameMap = SwiftProtobuf._NameMap(bytecode: "\0\u{1}data\0\u{3}tunnel_info\0")
~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with PR #282 and the generated file mitmproxy-macos/redirector/ipc/mitmproxy_ipc.pb.swift, then inspect the autofix CI configuration where swift-protobuf is disabled. Update SwiftProtobuf to support the generated Swift files and re-enable swift-protobuf in that job. Done means the macOS autofix CI job passes without the _NameMap compilation error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100