mitmath / mitmath/computational-thinking

hw1 quantize check

Open
#30 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
2.8k
Forks
502
PR merge metrics
No merged PRs in 30d

Description

I feel like the check might be inadequate?

https://github.com/mitmath/18S191/blob/123040947d5b03a572b58c261b3009c8041b5c4e/homework/homework1/hw1.jl#L986-L1000

Since it is checking 0.3, floor with any digits ≥ 1 will pass, when really we want digits=1.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open homework/homework1/hw1.jl at lines 986-1000 and inspect the quantize check for the 0.3 case. Confirm that the check requires digits=1 rather than allowing any digits value that makes floor pass; done means the check rejects larger digits values.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.