mitchellh / mitchellh/vouch

Denouncing a second time with a reason doesn't update `VOUCHED.td`

Open
#75 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Nushell
Stars
5.1k
Forks
91
PR merge metrics
No merged PRs in 30d

Description

observed in https://github.com/conda/rattler/pull/2126#issuecomment-3969570721
workflow: https://github.com/conda/rattler/blob/bb93194fe4cc50eb92976d932c196a316f7f1e3b/.github/workflows/vouch-manage-by-issue.yml, https://github.com/conda/rattler/actions/runs/22463709957/job/65064417973?pr=2126

Image Image

I would have expected that vouch updates the denounced entry in VOUCHED.td with the reason provided. Instead, vouch didn't do anything with the message ... is already denounced. Probably the same issue holds when vouching (didn't test this)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reported workflow in .github/workflows/vouch-manage-by-issue.yml and the linked pull-request comment and Actions job. Reproduce a second denounce with a reason, then trace the vouch entry point that reports “already denounced.” Done means the existing entry in VOUCHED.td is updated with the new reason; the analogous vouching behavior is not confirmed by the report.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.