mistic100 / mistic100/jQuery-QueryBuilder
Use the multiple property of rule operator instead of filter
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.7k
- Forks
- 544
- PR merge metrics
- No merged PRs in 30d
Description
I have similar needs as this https://github.com/mistic100/jQuery-QueryBuilder/issues/474
But as it is pointed by the author, changing the select element multiple attributes won't work (without special handling). https://github.com/mistic100/jQuery-QueryBuilder/issues/474#issuecomment-295874269.
But we have the multiple property at operator level.
Could we use rule.operator.multiple instead of filter.multiple here?
https://github.com/mistic100/jQuery-QueryBuilder/blob/dev/src/data.js#L378
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/data.js around line 378 and read the linked issue discussion for the existing multiple-selection behavior. Check how rule.operator.multiple and filter.multiple are used, then verify that the operator-level property controls the rule UI as requested. The issue is done when the behavior no longer depends on filter.multiple in this case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, jquery
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 38/100