mirumee / mirumee/saleor-app-framework-python

"x-saleor-*" headers are deprecated and replaced with "saleor-*" starting with v4

Open
#29 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
61
Forks
24
PR merge metrics
No merged PRs in 30d

Description

Saleor v4 will be deprecating x-saleor-* headers, using only saleor-* in its requests.

We are using those headers in places like this:

https://github.com/saleor/saleor-app-framework-python/blob/7329447529f03f6067ef390d080a0f930d98eb5f/src/saleor_app/deps.py#L16

Source: Saleor Integration Docs

Zrzut ekranu 2022-03-21 o 14 37 23

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/saleor_app/deps.py at the linked line and search the repository for other x-saleor-* header uses. Compare each occurrence with the Saleor Integration Docs linked in the issue. Done means the framework uses the saleor-* names required for Saleor v4 wherever these headers appear.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.