mirumee / mirumee/saleor-app-framework-python

Use logic from `require_permission` by default

Open
#10 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
61
Forks
24
PR merge metrics
No merged PRs in 30d

Description

We have a dependency that is responsible for checking the required app permissions vs permissions received from a token.
This should be used in the case when we use endpoints for communicating with iframe. Would be good to have an interface that will force you to determine expected permission in case of usage a deps for forms

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing require_permission logic and the endpoints used for iframe communication, then inspect how dependencies are used for forms. Done should mean those endpoints use the permission check by default and form dependencies require an expected permission to be specified.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, authorization, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.