miracle2k / miracle2k/android-platform_sdk
Content of META-INF/services has to be retained in a build result
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 68
- Forks
- 103
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/miracle2k/android-platform_sdk/blob/a43666cc4f8d3e9eaf0ef7bdb24696c02c2622b5/sdkmanager/libs/sdklib/src/com/android/sdklib/build/ApkBuilder.java#L737
It looks like META-INF and below directories are not included in the produced results, however META-INF/services may include for app functionality content. META-INF has to be excluded from the check, or at least services sub-directory. It isn't clear how it can be done without changing the code.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at sdkmanager/libs/sdklib/src/com/android/sdklib/build/ApkBuilder.java around line 737 and inspect the check that excludes META-INF entries from produced results. Determine how META-INF/services content is handled, then verify that service files are retained while the existing build behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system, mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100