minorsecond / minorsecond/BuzzBot

Fix casting in tests

Open
#407 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug good first issue hacktoberfest
Dominant language
C++
Stars
7
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
Currently, tests give us graphing_calculations.cpp:100:37: warning: use of old-style cast to ‘int’ [-Wold-style-cast].

To Fix
Need to change auto timet = (int)std::mktime(&t); to something like auto timet = static_cast<int>std::mktime(&t);

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open graphing_calculations.cpp at line 100 and inspect the old-style cast around std::mktime. Replace that cast with the requested C++ cast form, then build the project and confirm the -Wold-style-cast warning is gone.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.