Question: Wrong keycode expected when using shift modifier in EventsTest::testKeybordEvents?

Open
#36 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
php
Domain
testing

Research direction

Start with tests/Js/EventsTest.php at lines 104-105 and the provider at line 117. Reproduce the keyboard event test for plain r and Shift+r, then align the assertion with the observed keycodes and run EventsTest to confirm the expected behavior.

Written by the indexing model from the issue text.

Description

When I send "r" to the browser then keycode 114 is used but when I send r and modifier shift to browser then keycode 82 is used.
I encounter a problem because test case always expects keycode 114.

Assertion:
https://github.com/minkphp/driver-testsuite/blob/d208035ccc5eaf4f1def0299a1979c1851a9a0fb/tests/Js/EventsTest.php#L104-L105 Provider: https://github.com/minkphp/driver-testsuite/blob/d208035ccc5eaf4f1def0299a1979c1851a9a0fb/tests/Js/EventsTest.php#L117

Pressed r:
image
Pressed shift+r:
image

Dominant language
PHP
Stars
8
Forks
29
Avg merge
22h 21m
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from minkphp/driver-testsuite

All issues in minkphp/driver-testsuite

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.