Auto-start session only upon 1st "->visit(...)" method call breaks my test suite
Open
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 1.6k
- Forks
- 286
- PR merge metrics
- No merged PRs in 30d
Description
PR #705 from @aik099 breaks my testsuite as I am resizing the Window prior to each scenario.
class FeatureContext extends RawMinkContext
{
use KernelDictionary;
/**
* @BeforeScenario
*/
public function beforeScenario()
{
if ($this->getSession()->getDriver() instanceof Selenium2Driver) {
$this->getSession()->resizeWindow(1440, 900, 'current');
}
}
}
This breaks with the error:
┌─ @BeforeScenario # AppBundle\Features\Context\FeatureContext::beforeScenario()
│
╳ Fatal error: Call to a member function window() on null (Behat\Testwork\Call\Exception\FatalThrowableError)
│
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with PR #705 and the FeatureContext example, then trace getSession()->getDriver() and resizeWindow(1440, 900, 'current') through Selenium2Driver. Reproduce the failure when resizing occurs before any visit call; done means the @BeforeScenario resize works without the null-window fatal error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100