minkphp / minkphp/Mink

Using the named content selector even looks in javascript String literals

Open
#728 2 comments 0 reactions 1 assignee View on GitHub

@stof is already working on this.

Since Dec 20, 2016.

Dominant language
PHP
Stars
1.6k
Forks
286
No merged PRs in 30d

Description

Finding elements with find('named', ['content', 'some string']) looks even in tags, and returns those elements if it does find an equivalent String literal anywhere in there. I don't think this should happen.

Opened in https://github.com/jcalderonzumba/MinkPhantomJSDriver/issues/58 by @thedamnedrhino

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.