minkphp / minkphp/Mink

Add opportunity to provide all values for a cookie in setCookie method

Open
#724 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
1.6k
Forks
286
PR merge metrics
No merged PRs in 30d

Description

Currently setCookie accepts only name and value. I suggest extending this so that the method accepts all other possible parameters: domain and expiry (not sure about secure though) as described here.

The change implies adding parameters to the inteface DriverInterface and implementation in drivers.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the DriverInterface and the driver implementations mentioned in the issue, then compare their setCookie methods with the referenced WebDriverOptions::addCookie documentation. Confirm which cookie parameters are supported, including whether secure is appropriate, and update the interface and implementations consistently. Done means callers can provide the supported cookie values through setCookie.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.